Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidebar Redesign #1046

Merged
merged 3 commits into from
Mar 29, 2017
Merged

Sidebar Redesign #1046

merged 3 commits into from
Mar 29, 2017

Conversation

skipjack
Copy link
Collaborator

Redesigning the sidebar to match @pastelsky's comp (see #438).

This is phase one of two for getting everything discussed in #438 (and things mentioned in some other issues like #1039) knocked out. My next task is updating the structure of the /content directory, the antwar config, etc to match our actual hierarchy in the site. This should allow us to map the banner links more dynamically and to allow grouping in the sidebar (with a few more tweaks).

Changes:

  • Changing webpack version in sidebar to an image shield
  • Updating sidebar design to come closer to the comp
  • Doing some code cleanup/refactoring

Here's a gif of the updates:

skipjack added 3 commits March 22, 2017 08:50
@skipjack
style: tweak sizing of page sections
836f93f
@skipjack
docs: sorting and renaming some configuration docs
63ce480
@skipjack
feat: redesigning the sidebar
a7ee1ea 
Using an img shield to display the webpack version
Updating the styling to match @pastelsky's comp (see #438)
Cleaning up some of the code in Sidebar and SidebarItem
@skipjack
Copy link
Collaborator Author

@SpaceK33z if you have time could you give this a quick go and see if anything needs fixing/tweaking?

@scottdj92
Copy link
Contributor

Is there a reason why you switched from % based values to px based?

@skipjack
Copy link
Collaborator Author

skipjack commented Mar 22, 2017 •
edited
Loading

@scottdj92 you mean in page-style.scss? I just wanted to ensure the sidebar always had enough room to look decent however I don't feel too strongly about that change... if you want to propose some widths that you think look better on more screens I'm definitely open to it.

@scottdj92
Copy link
Contributor

Oh no I trust you. I was just asking about it, because I know % based widths scale a bit better than direct px.

@skipjack
Copy link
Collaborator Author

Yea there are some screens in between our largest width and smallest width (e.g. like around 750px - 900px) that look a bit tight both in the sidebar and content areas). One option would be to break to our mobile view a bit earlier.

Probably worth playing around with a bit more.

@skipjack skipjack merged commit 41919b9 into master Mar 29, 2017
@skipjack
Copy link
Collaborator Author

Merged as I think this is a pretty significant improvement over what we have now.

@SpaceK33z @webpack/documentation-team feel free to to test and ping me or create a ticket if you notice any issues.

@skipjack skipjack deleted the sidebar-redesign branch March 29, 2017 02:17
@skipjack skipjack mentioned this pull request Apr 10, 2017
Closed
@skipjack skipjack mentioned this pull request May 7, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skipjack @scottdj92